Rants

#1... reading my posts here... most stink! well except for me... they are kind of like notes to myself... and completely worthless to everybody else... I guess I should spend a few extra minutes and make them a bit les cryptic... and ...right down to earth in a language everybody can easily understand...

#2... I just don't understand... I am a professional programmer... and I got to this point by teaching myself my craft... learning from books... I learned the hard way and figured that most programmers had a leg up on me with their formal education... yet amazingly that isn't the case... perhaps it is the nature of inter/intranet apps... that many were created by novices and now the pro's have to come and clean up... I rarely if ever encounter code written by others that I would consider "ok" or ever "good"...

I know that programmers tend to have a myopic view of coding... my stuff good... everything else bad! BUT really... Am I out of line or is this complete garbage...

Sub ProcessOutput()
        If Not ValidateQueryString() Then
            Exit Sub
        End If

        ' We'll use these variables throughout
        mMfrId = Request.QueryString("mfr_id")
        mMfrDeleteId = Request.QueryString("mfr_delete_id")

        Dim aMfrIdParm(,) As String = {{"@mfr_id", SqlDbType.Int, mMfrId}}
        Dim aMfrDeleteIdParm(,) As String = {{"@mfr_delete_id", SqlDbType.Int, mMfrDeleteId}}

        Select Case Trim(Request.QueryString("step"))
            Case "1"
                Step1(aMfrIdParm)
            Case "1a"
                Step1a(aMfrIdParm)
            Case "2"
                Step2(aMfrIdParm)
            Case "2a"
                Step2a(aMfrDeleteIdParm)
            Case "3"
                Step3(aMfrIdParm)
            Case "3a"
                Step3a(aMfrDeleteIdParm, aMfrIdParm)
            Case Else
        End Select

    End Sub

Come on... what a great comment...

' We'll use these variables throughout
FOR WHAT!? what kind of arbitrary made up garbage is this... hmm... mMfrId yeah I know what a mMfr is I'll guess it is a manufacturer... but since we are still under the oppression of character restrictions in our variable names... I guess this is acceptable... Instead of making logical names... just call things step 1, 2,3 instead of saying what they really do... better yet... lets just hard code some values in to this program as well...

Function ReturnLName(ByVal sName As String) As String
        Select Case LCase(sName)
            Case "amadeupnametoprotecttheinnocent1"
                Return "Amadeupnametoprotecttheinnocent1"
            Case "amadeupnametoprotecttheinnocent2"
                Return "Amadeupnametoprotecttheinnocent2"
            Case "amadeupnametoprotecttheinnocent3"
                Return "Amadeupnametoprotecttheinnocent3"
            Case Else
                Return "System"
        End Select
    End Function 

There are several other functions just like this one to get peoples email addresses... not only is that function silly because all it does is capitolize the first letter of the name... and if not in the list of folks it know it uses system... it just uses hard coded values... so if so and so #1 leaves the company... we have to edit the program... NICE! I love arbitrary code... and hard coded values... :-)... My two favorite things... OH and code you can't test because it will interactive with live systems... or code that sends emails out to people and you can't turn them off or have them all redirected to a single mailbox...

OK enough ranting... well one more... I hate people that over used the elipse "..."